Skip to content

Bump annotatedyaml to 0.4.4#140861

Merged
bdraco merged 5 commits intodevfrom
annotatedyaml_042
Mar 19, 2025
Merged

Bump annotatedyaml to 0.4.4#140861
bdraco merged 5 commits intodevfrom
annotatedyaml_042

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented Mar 18, 2025 •
edited
Loading

Proposed change

changelog: home-assistant-libs/annotatedyaml@v0.2.0...v0.4.4

~30% performance improvement
https://codspeed.io/home-assistant-libs/annotatedyaml/runs/compare/67d6394a7e6117b20d9eff87..67da6a2f9255bc74ff5fb2af

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed core dependency small-pr PRs with less than 30 lines. labels Mar 18, 2025
@bdraco
Copy link
Member Author

bdraco commented Mar 18, 2025

pylint can't see them, but they are there. Probably better to add top level exports

>>> from annotatedyaml.objects import Input
>>> from annotatedyaml.objects import NodeDictClass, NodeListClass, NodeStrClass
>>> NodeStrClass("x")
'x'

bdraco added a commit to home-assistant-libs/annotatedyaml that referenced this pull request Mar 18, 2025
@bdraco
fix: export node classes at top level
21c9351 
pylint cannot see the cythonized versions but it should
be able to see the top level ones

home-assistant/core#140861 (comment)
@bdraco bdraco mentioned this pull request Mar 18, 2025
Merged
@bdraco
Copy link
Member Author

bdraco commented Mar 18, 2025

one more small fix needed home-assistant-libs/annotatedyaml#20

@bdraco bdraco changed the title Bump annotatedyaml to 0.4.2 Bump annotatedyaml to 0.4.3 Mar 18, 2025
@bdraco bdraco marked this pull request as ready for review March 18, 2025 10:43
@bdraco bdraco requested a review from a team as a code owner March 18, 2025 10:43
@bdraco
Copy link
Member Author

bdraco commented Mar 18, 2025

We can get another 12-14% out of it if yaml/pyyaml#848 merges

@bdraco
Copy link
Member Author

bdraco commented Mar 18, 2025

thanks

@MartinHjelmare
Copy link
Member

MartinHjelmare commented Mar 18, 2025 •
edited
Loading

I think the test failures may be related since they concern YAML reloading.

@MartinHjelmare MartinHjelmare marked this pull request as draft March 18, 2025 11:37
@thecode
Copy link
Member

thecode commented Mar 18, 2025 •
edited
Loading

I think the test failures may be related since they concern YAML reloading.

Tests group 5 looks related to this bump, group 7 is fixed by #140877

@bdraco
Copy link
Member Author

bdraco commented Mar 18, 2025

I agree it looks related, will dig into it

@bdraco
Copy link
Member Author

bdraco commented Mar 18, 2025

Sorted out the issue in home-assistant-libs/annotatedyaml#23 with an alternate solution

@bdraco bdraco changed the title Bump annotatedyaml to 0.4.3 Bump annotatedyaml to 0.4.4 Mar 19, 2025
@bdraco bdraco marked this pull request as ready for review March 19, 2025 08:23
@bdraco bdraco merged commit f4fe234 into dev Mar 19, 2025
59 checks passed
@bdraco bdraco deleted the annotatedyaml_042 branch March 19, 2025 08:26
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thecode thecode thecode approved these changes

@jpbede jpbede jpbede approved these changes

Assignees

No one assigned

Labels

cla-signed core dependency small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bdraco @MartinHjelmare @thecode @jpbede